Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: display git commit version #556

Merged
merged 1 commit into from
Jan 10, 2025
Merged

feat: display git commit version #556

merged 1 commit into from
Jan 10, 2025

Conversation

kittybest
Copy link
Collaborator

@kittybest kittybest commented Dec 16, 2024 •
edited
Loading

Description

  • Read commit version before start, dev, and build, and write to the .env file.
  • display on the organizer board & footer

Related Issues
close #551

Discussion

  1. Is there any easier way to accomplish this?
  2. should the commit be displayed to everyone during the development mode? or only the organizer?
  3. where to put it?

@kittybest kittybest self-assigned this Dec 16, 2024
@vercel Vercel
Copy link

vercel bot commented Dec 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maci-platform ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 3:29pm

@kittybest kittybest marked this pull request as ready for review December 17, 2024 17:32
ctrlc03
ctrlc03 reviewed Jan 3, 2025
View reviewed changes
packages/interface/package.json Outdated Show resolved Hide resolved
packages/interface/package.json Outdated Show resolved Hide resolved
@ctrlc03 ctrlc03 force-pushed the feat/commit-version branch from 2dd3260 to 7bcf281 Compare January 3, 2025 09:23
@kittybest kittybest force-pushed the feat/commit-version branch 2 times, most recently from ba362c0 to 12807c5 Compare January 3, 2025 17:25
@kittybest kittybest force-pushed the feat/commit-version branch 2 times, most recently from 041dc38 to 28a55ef Compare January 8, 2025 16:40
ctrlc03
ctrlc03 approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@kittybest kittybest force-pushed the feat/commit-version branch from 28a55ef to 2b4fa32 Compare January 10, 2025 13:16
@kittybest kittybest force-pushed the feat/commit-version branch 2 times, most recently from 041dc38 to b40c54d Compare January 10, 2025 14:59
@kittybest kittybest force-pushed the feat/commit-version branch from b40c54d to 22bed13 Compare January 10, 2025 15:08
@kittybest kittybest enabled auto-merge January 10, 2025 15:08
@kittybest kittybest merged commit 8133dd9 into main Jan 10, 2025
17 checks passed
@kittybest kittybest deleted the feat/commit-version branch January 10, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctrlc03 ctrlc03 ctrlc03 approved these changes

@0xmad 0xmad Awaiting requested review from 0xmad

@crisgarner crisgarner Awaiting requested review from crisgarner crisgarner is a code owner

Assignees

@kittybest kittybest

Labels
None yet
Projects
MACI Platform
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat(interface): show commit version to the deployed website
2 participants
@kittybest @ctrlc03